Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

COMMISSION_FEE cannot be changed freely

Summary

The COMMISSION_FEE cannot be changed freely.

Vulnerability Details

Distributor.sol contract states that the commission fee can be changed in the future, but that would mean recreating the whole distributor contract and changing the fees. Would be great if commission fee can be set by the owner, with a max cap of 1000. Otherwise, it is unknown how the commission fee would change and how much it would change by.

uint256 private constant COMMISSION_FEE = 500; // this can be changed in the future

Setting as low impact.

Impact

COMMISSION_FEE cannot be changed freely.

Tools Used

Manual Review

Recommendations

Recommend adding a function in the code that allows the owner to change the commission fee freely, and put a max cap on the commmission fee.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.