Sparkn

Summary

The ProxyFactory contract's constructor iterates over the _whitelistedTokens[] without explicitly checking its length. This could lead to unbounded iteration and potential gas exhaustion if the _whitelistedTokens[] too much addresses inserted.

Vulnerability Details

In ProxyFactory contract code, the constructor attempts to iterate over the _whitelistedTokens[] to whitelist the specified tokens. However, the constructor doesn't include a check to ensure that the array is not full of token addresses that consume more gas and leads to out of gas error. It is noted that constructor checks that _whitelistedTokens[] is non-empty.

Impact

1. Unbounded iteration can lead to excessive gas consumption.

2. Transactions that call the constructor with too much addresses, _whitelistedTokens[] may fail due to out-of-gas errors.

3. The contract deployment process may become expensive or infeasible if gas limits are exceeded.

Tools Used

Recommendations

Add a condition at the beginning of the constructor to check the length of _whitelistedTokens[]. If the length is too much that consumes lot of gas then revert.