Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

Incorrect EIP712 implementation

Summary

Incorrect EIP712 implementation

Vulnerability Details

The implementation of EIP712 in the deployProxyAndDistributeBySignature() deviates from the EIP712 standard due to the following reasons:

  1. No typehash is included

  2. bytes data type is used directly instead of using the keccak256 hash of their contents

https://eips.ethereum.org/EIPS/eip-712

Impact

Possible failure when the user tries to sign using existing libraries

Tools Used

Manual review

Recommendations

Follow the EIP712 guidelines

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.