Submission Details
Severity:
Use of abi.encodePacked with dynamic types inside keccak256
Vulnerability Details
abi.encodePacked should not be used with dynamic types when passing the result to a hash function such as keccak256.
function getProxyAddress(bytes32 salt, address implementation) public view returns (address proxy) {
bytes memory code = abi.encodePacked(type(Proxy).creationCode, uint256(uint160(implementation)));
bytes32 hash = keccak256(abi.encodePacked(bytes1(0xff), address(this), salt, keccak256(code)));
proxy = address(uint160(uint256(hash)));
}
Impact
To prevent any hash collisions.source
Tools Used
Manual Review
Recommendations
Use abi.encode instead, which will pad items to 32 bytes
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.