Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Solidity functions visibility can be improved

Summary

Certain public functions not called by the contract should be declared external instead.
Certain internal functions called only within a contract should be declared as private instead.

From Distributor.sol:

_isWhiteListed

_commissionTransfer

_distribute

All these functions can be restricted to private, because they are used only in the contract they are defined in and not in derived contracts

From ProxyFactory.sol:

_calculateSalt to private
_deployProxy to private

Because they are used only in the contract they are defined in and not in derived contracts.

getProxyAddress to external

distributeByOwner to external

deployProxyAndDistributeByOwner to external

deployProxyAndDistributeBySignature to external

deployProxyAndDistribute to external

setContest to external

Because they are never used internally.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.