Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

`whitelistedTokens`whitelistedTokens are only allowed to be added at creation time, which makes the protocol unhealthy

Summary

whitelistedTokenswhitelistedTokens are only allowed to be added at creation time, which makes the protocol unhealthy.
If the creator forgets to add some important tokens, or some kind of popular stable token appears in the market, but the contract does not support these tokens, this will affect the popularity and influence of the protocol

Vulnerability Details

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L81

Impact

If the creator forgets to add some important tokens, or some kind of popular stable token appears in the market, but the contract does not support these tokens, this will affect the popularity and influence of the protocol

Tools Used

manual

Recommendations

We can add addwhitelistedTokens() and deletewhitelistedTokens() function and set it being onlyOwner

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.