Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

The parameter implementation may be set incorrectly by mistake If there are many proxy implementation. It's better to store it as storage in ProxyFactory Contract.

Summary

The parameter implementation may be set incorrectly by mistake If there are many proxy implementation. It's better to store it as storage in ProxyFactory Contract.

Vulnerability Details

Impact

Tools Used

manual

Recommendations

address public implementation;
function setimplementation(address _implementation)public onlyOwner{
if ( implementation == address(0)) revert ProxyFactory__NoZeroAddress();
implementation = _implementation;
}

Then it is no need to have parameter implementation in function setContest.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.