Sparkn

Summary

It's not possible to add or remove tokens from the whitelist which could be an issue in the future, the project would need to redeploy the ProxyFactory and Distributor contracts.

Vulnerability Details

While the implementation is well done, the inability to add or remove tokens from the whitelist could cause issues in the future. Redeploying the main contracts is necessary if the project wants to modify the list of accepted tokens since they are linked to the ProxyFactory and Distributor contracts. It is crucial to consider possible solutions like designing the contracts in a more flexible way or including a way to modify the whitelist without redeploying the entire system.

Impact

It is necessary to redeploy the project as both the Distributor and ProxyFactory are impacted.

Tools Used

Manual Review

Recommendations

It is recommended to add functions to add and remove tokens from whitelistedTokens arrays