Submission Details
Severity:
Dangling commented out code
Summary
There are two require statements that are commented out in the ProxyFactory.sol deployProxyAndDistributeByOwner function.
if (saltToCloseTime[salt] == 0) revert ProxyFactory__ContestIsNotRegistered();
if (saltToCloseTime[salt] + EXPIRATION_TIME > block.timestamp) revert ProxyFactory__ContestIsNotExpired();
// require(saltToCloseTime[salt] == 0, "Contest is not registered");
// require(saltToCloseTime[salt] < block.timestamp + EXPIRATION_TIME, "Contest is not expired");
Vulnerability Details
The commented out require statements is a repeat of the two if conditionals right above the require statements.
Impact
The second require statement's logic can be confusing for the developer and the user, and this can be uncommented with incorrect logic in the future.
Tools Used
Manual Analysis
Recommendations
Remove the commented code to prevent confusion.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477
USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.