Sparkn

Summary

The inline comment in ProxyFactory.deployProxyAndDistribute() states "can set close time to current time and end it immediately if organizer wish". However, the protocol does not allow for this.

Vulnerability Details

Note that:

1. Contest close times are only set in the setContest() function

2. setContest() does not allow setting a contest's close time to zero

3. A contest's close time can only be set once due to a nonzero check in setContest(), which causes a revert if the contest's close time is nonzero

4. deployProxyAndDistribute() reverts if the contest's close time is greater than block.timestamp

Therefore, it is impossible for organizers to immediately end their contests.

Impact

No funds are at risk, but the protocol does not function as documented/intended. Organizers are unable to end contests early.

Tools Used

Manual Review

Recommendations

Refactor or remove the relevant revert statement in ProxyFactory.deployProxyAndDistribute() so that organizers can end contests early.