Sparkn

Vulnerability Details

We are using a random value salt to calculate the Proxy contract address to be deployed but what if that contract already existed even before we deployed the ProxyFactory contract, then it will never lead to distribution of winnings to the winners. The chances of this happening is very-very low.

Impact

Very low impact

Tools Used

Manual

Recommendations

To add a mechanism which will handle this case and before creating a contest, it checks whether the contract at that address exists or not, so if it exists then we should use some approaches like checking it with next contest id or any other mechanism.