Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Owner not set in the Ownable constructor

Summary

The owner of the ProxyFactory is not set in the Ownable constructor

Vulnerability Details

If we inherit the Ownable contract from OpenZeppelin, which has a constructor that takes as an argument address initialOwner, we should set the initialOwner in the constructor. However in ProxyFactory when we call the Ownable constructor, the initialOwner is not set. This can lead either to the owner being the address(0) or the owner is set to the address of whichever contract deploys it.

Impact

This can lead to a different owner than expected which will invalidate the whole project.

Tools Used

Manual review

Recommendations

Add the initalOwner in the Ownable constructor.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!