Sparkn

Summary

saltToCloseTime[salt] > block.timestamp will always evaluate to false and contest will forever be open

Vulnerability Details

Vulnerability Details
salt doesn't store time: bytes32 salt = _calculateSalt(msg.sender, contestId, implementation);

Comparing salt to block.timestamp will thus evaluate to false every time.

Impact

Contest will always be considered open

Tools Used

Manual review

Recommendations

Compare a number with block.timestamp.