Sparkn

Vulnerability Details

OpenZeppelin maintains a library of standard, audited, community-reviewed, and battle-tested smart contracts.

Instead of always importing this contract, the Sparkn project reimplements them.

In particular, the following contracts and libraries are being reimplemented or copied:

the Proxy contract can be replaced with OpenZeppelin’s Proxy contract.

Consider importing the OpenZeppelin contracts instead of reimplementing or copying them.
The contract can be extended to add the extra functionalities required by Spark.

Impact

This increases the amount of code that the Sparksn team will have to maintain and misses all the improvements and bug fixes that the OpenZeppelin team is constantly implementing with the help of the community.

Tools Used

Manual review

Recommendations

Consider always using the full ERC interfaces so that obviously non-compliant implementations can be easily excluded.

Consider updating the library to its latest stable version for Solidity 0.8.20.