Submission Details
Severity:
Unbounded loop might cause gas griefing because of long winners.length
Summary
If winners.length is long, gas griefing inside loop is possible.
Vulnerability Details
uint256 winnersLength = winners.length; // cache length
for (uint256 i; i < winnersLength;) { // @audit - unbounded gas consumption
uint256 amount = totalAmount * percentages[i] / BASIS_POINTS;
erc20.safeTransfer(winners[i], amount);
unchecked {
++i;
}
}
Impact
DoS of Prize distribution
Tools Used
Manual Review
Recommendations
Should have maximum limit for winner length.
uint256 winnersLength = winners.length; // cache length
+ require(winnersLength <= MAX_WINNERS_LENGTH, Distributor__WinnersLengthReched());
for (uint256 i; i < winnersLength;) {
uint256 amount = totalAmount * percentages[i] / BASIS_POINTS;
erc20.safeTransfer(winners[i], amount); // @audit - any of the winner is blacklisted.
unchecked {
++i;
}
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.