Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Previous Next
Submission Details
Severity: medium

implementation contract can be an eoa

sv

Summary

In setContest there is no code size check for implementation

Vulnerability Details

implementation contract can be a eoa

Impact

funds for a contest can get stuck for whitelisted tokens

POC

Run forge test --mt testIfImplementationCanBeEOA -vvv

function testIfImplementationCanBeEOA() public {
// before
assertEq(MockERC20(jpycv2Address).balanceOf(user1), 0 ether);
assertEq(MockERC20(jpycv2Address).balanceOf(stadiumAddress), 0 ether);
​
bytes32 randomId_ = keccak256(abi.encode("Jason", "001"));
address[] memory tokens_ = new address[](1);
tokens_[0] = jpycv2Address;
address[] memory winners = new address[](1);
winners[0] = user1;
uint256[] memory percentages_ = new uint256[](1);
percentages_[0] = 9500;
bytes memory data = abi.encodeWithSelector(Distributor.distribute.selector, jpycv2Address, winners, percentages_, "");
​
vm.startPrank(factoryAdmin);
bytes32 randomId = keccak256(abi.encode("Jason", "001"));
proxyFactory.setContest(organizer, randomId, block.timestamp + 8 days, user2); // setting user2 address as implementation
vm.stopPrank();
bytes32 salt = keccak256(abi.encode(organizer, randomId, user2));
address proxyAddress = proxyFactory.getProxyAddress(salt, user2);
​
​
vm.startPrank(sponsor);
MockERC20(jpycv2Address).transfer(proxyAddress, 10000 ether);
vm.stopPrank();
// console.log(MockERC20(jpycv2Address).balanceOf(proxyAddress));
assertEq(MockERC20(jpycv2Address).balanceOf(proxyAddress), 10000 ether);
​
vm.warp(9 days);
vm.startPrank(organizer);
proxyFactory.deployProxyAndDistribute(randomId_, user2, data);
vm.stopPrank();
​
console.log("balance of user after distribute",MockERC20(jpycv2Address).balanceOf(user1));
// after
assertEq(MockERC20(jpycv2Address).balanceOf(user1), 0);
assertEq(MockERC20(jpycv2Address).balanceOf(stadiumAddress), 0);
}

Tools Used

Manual Review

Recommendations

Add a codesize check for the implementation & optionally a view method on the implementation can be called to check for right interface or make it adhere to the erc165 standard(https://eips.ethereum.org/EIPS/eip-165)

uint size;
assembly {
size := extcodesize(implementation)
}
if (size == 0) revert();

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.