Sparkn

Summary

Read-only re-entrancy with transfer hooks

Vulnerability Details

Functions calling contracts with transfer hooks are missing reentrancy guards.

Impact

Even if the function follows the best practice of check-effects-interaction, not using a reentrancy guard when there may be transfer hooks will open possibility to read-only reentrancies with no way to protect against it.

Tools Used

Manual code analysis

Recommendations

Implement the CEI pattern before making external calls with also placing re-entrancy guard modifier.