Prize distribution can be wrongly calculated
Summary
Data given in different functions of ProxyContracts for distribution of prices is not validated properly.
Vulnerability Details
_distribute.ProxyContract did not get validation when passed in _distribute function,Prize distribution without any data will not be possible and the prizes can get lost due to unchecked data length.
_distribute(proxy, data);
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L136
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L165
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L191
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L217
Impact
Tools Used
Manual Review
Recommendations
add a check for data.length > 0
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.