Submission Details
Severity:
Avoid double casting
Summary
[L-01] Avoid double casting
Consider refactoring the following code, as double casting may introduce unexpected truncations and/or rounding issues.
Furthermore, double type casting can make the code less readable and harder to maintain, increasing the likelihood of errors and misunderstandings during development and debugging.
file: /src/ProxyFactory.sol
///@audit uint256(uint160
226 bytes memory code = abi.encodePacked(type(Proxy).creationCode, uint256(uint160(implementation)));
///@audit (uint160(uint256
228 proxy = address(uint160(uint256(hash)));
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L228
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.