Submission Details
Severity:
Functions calling contracts/addresses with transfer hooks are missing reentrancy guards
Summary
[L-05] Functions calling contracts/addresses with transfer hooks are missing reentrancy guards
Even if the function follows the best practice of check-effects-interaction, not using a reentrancy guard when there may be transfer hooks will open the users of this protocol up to read-only reentrancies with no way to protect against it, except by block-listing the whole protocol.
file: /src/Distributor.sol
164 token.safeTransfer(STADIUM_ADDRESS, token.balanceOf(address(this)));
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/Distributor.sol#L164
file: /src/Distributor.sol
147 erc20.safeTransfer(winners[i], amount);
https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/Distributor.sol#L147
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.