Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

Missing contract-existence checks before low-level calls

Missing contract-existence checks before low-level calls

  • Severity: Low

  • Confidence: High

Description

Low-level calls return success if there is no code present at the specified address. In addition to the zero-address checks, add a check to verify that <address>.code.length > 0 or use the extcodesize assembly operation to verify the presence of contract code at the specified address. Both these methods ensure the existence of a contract before making a low-level call.

There are 1 instances of this issue:

  • File: src/ProxyFactory.sol

Line: 250 (bool success,) = proxy.call(data)

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L250

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.