Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

Single-step ownership change introduces risks

Summary

Single-step ownership transfers add the risk of setting an unwanted owner by accident (this includes address(0)) if the ownership transfer is not done with excessive care. The ownership control library Owned by Solmate implements a simple single-step ownership transfer without zero-address checks.

Vulnerability Details

The code is inheriting from OZ Ownable rather than OZ Ownable2Step or other 2 steps option. This allow the owner to transfers to zero address and to transfer to a wrong address with a typo, and therefore lose ownership forever.

Impact

Owner role can be lost forever

Tools Used

Manual Review

Recommendations

Consider employing 2 step ownership transfer mechanisms for this critical ownership, such as Open Zeppelin's Ownable2Step or Synthetic's Owned.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.