Submission Details
Severity:
Incorrect Error naming in _distribute
Vulnerability Details
The proxyFactory#_distribute method calls the proxy with data as params.
It then checks for the call success using the returned variable success.
But it emits the wrong event.
This is a static call not a Delegate call.
function _distribute(address proxy, bytes calldata data) internal {
(bool success,) = proxy.call(data);
if (!success) revert ProxyFactory__DelegateCallFailed();
..
}
Impact
Misleading for the users interacting with the protocol
Loss of user's confidence on platform
Tools Used
Manual review
Recommendations
Rename the error to ProxyFactory__DistributionCallFailed()
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.