Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Off-By-One Timing Issue in EXPIRATION_TIME Check

Summary

If any one contract depending on this function does something exactly the time it's suppose to finish it will revert because it's using > instead of >=

Vulnerability Details

if (saltToCloseTime[salt] + EXPIRATION_TIME > block.timestamp)

Impact

The owner trying to call distributeByOwner wont be able to distribute at the exact moment it ends. it might not be a big thing but if other contracts are schedule to do something at the time the contest finishes they will all revert since they have to wait 1 second because it's > instead of >=.

Tools Used

Manual

Recommendations

Change from > to >=

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.