Submission Details
Severity:
Function arguments passed to setPassword() function can be read onchain
Vulnerability Details
Value of a setPassword() function parameter can be read onchain through block explorers like Etherscan.
26: function setPassword(string memory newPassword) external {
27: s_password = newPassword;
28: emit SetNetPassword();
29: }
Impact
Anyone can read the values of setPassword() function arguments onchain when called by the owner.
Tools Used
Manual Review
Recommendations
Consider keccak256 hashing the password before supplying it to the setPassword() function call.
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-read-storage
Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.