Submission Details
Severity:
Missing access control on `PasswordStore::setPassword` allows anybody to overwrite the original password
Summary
Changing password is done via PasswordStore::setPassword and should be doable only by the owner of the contract (deployer).
Because of a missing check that caller is owner, anyone can overwrite the original password.
https://github.com/Cyfrin/2023-10-PasswordStore/blob/main/src/PasswordStore.sol#L22-L28
/*
* @notice This function allows only the owner to set a new password.
* @param newPassword The new password to set.
*/
function setPassword(string memory newPassword) external {
s_password = newPassword;
emit SetNetPassword();
Tools Used
Manual review
Recommendations
Add a check that msg.sender is s_owner in setPassword.
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.