Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Incorrect `@param` and missing `@return` Natspace for `getPassword(...)`

Summary

The natspac used for getPassword(...) is incorrect

Vulnerability Details

getPassword(...) doesn't take anything as a parameter. It only returns the password string. The following natspac is incorrect:

File: 2023-10-PasswordStore/src/PasswordStore.sol
33 * @param newPassword The new password to set.

Also it has missing natspac about the return value.

Impact

Incorrect natspac

Tools Used

Manual Review

Recommendations

Add the following changes:

File: 2023-10-PasswordStore/src/PasswordStore.sol
/*
* @notice This allows only the owner to retrieve the password.
- * @param newPassword The new password to set.
+ * @return stored password string for the owner. Reverts if msg.sender is not owner
*/
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 2 years ago
inallhonesty Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.