Submission Details
Severity:
Missing Access Control in setPassword()
Summary
only Owner of the contract should be able to change it's password but there is no modifier that restricts any user from changing password
Vulnerability Details
/*
* @notice This function allows only the owner to set a new password.
* @param newPassword The new password to set.
*/
//E @audit missing onlyOwner modifier
function setPassword(string memory newPassword) external {
s_password = newPassword;
emit SetNetPassword();
}
Impact
Anyone can set new password and owner will lose it's old password
Tools Used
VSCode
Recommendations
function setPassword(string memory newPassword) external {
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.