Submission Details
Severity:
Anyone can change the password
Summary
The function setPassword does not have a check that would restrict calls from anyone other than the contract owner.
Vulnerability Details
The setPassword function allows anyone to set a new password.
Impact
This vulnerability has a severe impact since it allows anyone to change the password.
function test_anyone_can_set_password() public {
/* Not owner account*/
vm.startPrank(address(1));
string memory expectedPassword = "myNewPassword2";
passwordStore.setPassword(expectedPassword);
/* Owner account */
vm.startPrank(owner);
string memory actualPassword = passwordStore.getPassword();
assertEq(actualPassword, expectedPassword);
}
Tools Used
Foundry
Recommendations
Check who is calling the setPassword function
function setPassword(string memory newPassword) external {
+ if (msg.sender != s_owner) {
+ revert PasswordStore__NotOwner();
+ }
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.