First Flight #1: PasswordStore

Summary

Events should be named correctly

Vulnerability Details

It is possible event SetNetPassword() is named incorrectly and the proper required name was SetNewPassword
If this was not in error event name is still not ideal

Impact

This may have usability, monitoring, off-chain tooling problems, front end problems and even security. For example tooling may be expecting SetNewPassword() and miss when password is changed inappropriately as it was receiving SetNetPassword()

Tools Used

Manual Analysis

Recommendations

Name events appropriately e.g SetNewPassword() to SetNewPassword()