Submission Details
Severity:
Missing access control on `setPassword`
Summary
Missing validation/access control on setPassword function.
Vulnerability Details
There is no validation on the setPassword's caller, as a result anyone can set the password for this password store.
Impact
The password can be set by any value by anyone:
function test_free_set_password() public {
vm.prank(address(0x123));
string memory expectedPassword = "hackerPassword";
passwordStore.setPassword(expectedPassword);
vm.prank(owner);
string memory actualPassword = passwordStore.getPassword();
assertEq(actualPassword, expectedPassword);
}
Tools Used
Manual, Foundry
Recommendations
Recommend adding access control to the setPassword function.
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.