Submission Details
Severity:
PasswordStore::setPassword() lags only owner check.
Summary
The function setPassword's NatSpec mentions that only owner should be allowed to change it, but it can be changed by anyone as it lags the only owner check.
Vulnerability Details
If there is no only owner check, then anyone can call the setPassword function and can change the password anytime.
Impact
Owner will get wrong password.
Tools Used
Manual Review
Recommendations
To add a only owner check.
function setPassword(string memory newPassword) external {
+ if (msg.sender != s_owner) {
+ revert PasswordStore__NotOwner();
+ }
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.