Submission Details
Severity:
Anybody can set new password
Summary
In the comment of the setPassword function it is said that only the owner should be able to set the password, but there is no check for it.
Vulnerability Details
As anybody can set the password, it breaks the whole logic behind the protocol, which main purpose is to store the password of the only owner and only him be able to change it
Impact
Unpredictable behaviour
Tools Used
Manual Review
Recommendations
Check if the msg.sender is the owner and if no -> revert :
/*
* @notice This function allows only the owner to set a new password.
* @param newPassword The new password to set.
*/
function setPassword(string memory newPassword) external {
require(msg.sender == s_owner, "Should be owner");
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
about 2 years ago
inallhonesty about 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.