Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

@param newPassword should be made calldata instead or memory

Summary

The newPassword parameter in setPassword(string memory newPassword) should be made calldata the argument will not be modified during the function's call existence.

Vulnerability Details

Impact

If it is made calldata, this can save up tp 1% of gas used when calling this function

Tools Used

Manual Review

Recommendations

Change memory to calldata to save gas

    1. function setPassword(string memory newPassword)

    1. function setPassword(string calldata newPassword)

Updates

Lead Judging Commences

inallhonesty Lead Judge
about 2 years ago
inallhonesty Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.