Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

H-01. Missing onlyOwner check while calling setPassword

Summary

The onlyOwner check is missing while setPassword is getting called. Which will allow anyone to rewrite the password that owner has set.

Impact

Anybody can rewrite the set password in the contract.

Tools Used

VS code

Recommendations

Create a onlyOwner modifier or add a manual check before setting the password

function setPassword(string memory newPassword) external {
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
s_password = newPassword;
emit SetNetPassword();
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 2 years ago
inallhonesty Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-lacking-access-control

Anyone can call `setPassword` and set a new password contrary to the intended purpose.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.