Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

[L-0] Redundant checks should be moved to a modifier

Summary

Redundant checks should be converted into a modifier.

Vulnerability Details

N/A

Impact

N/A

Tools Used

Manual review.

Recommendations

It is considered best practice for checks such as the one below to be converted to a modifier. Better yet, the modifier logic moved to a function that gets called in the modifier.

if (msg.sender != s_owner) {
revert PasswordStore__CallerIsNotOwner();
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 2 years ago
inallhonesty Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.