Submission Details
Severity:
Anyone can set the password using ``setPassword()`` function.
Summary
Anyone can set new password using setPassword() function but that shouldn't be the case.
Vulnerability Details
Only owner who deployed this contract should be able to set new password but anyone can call setPassword() function to set new password.
Impact
Malicious user can set the password to random which will grief the owner as the owner will retrieve incorrect password.
Tools Used
Manual Analysis
Recommendations
Add proper access control to the setPassword() function like:
./PasswordStore.sol
26. function setPassword(string memory newPassword) external {
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
s_password = newPassword;
emit SetNetPassword();
}
Updates
Lead Judging Commences
inallhonesty
almost 2 years ago
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
finding-lacking-access-control
Anyone can call `setPassword` and set a new password contrary to the intended purpose.
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.