First Flight #1: PasswordStore

Summary

Wrong event and emit statement - event SetNetPassword();

Vulnerability Details

event SetNetPassword()
https://github.com/Cyfrin/2023-10-PasswordStore/blob/856ed94bfcf1031bf9d13514cb21b591d88ed323/src/PasswordStore.sol#L16

emit SetNetPassword();
https://github.com/Cyfrin/2023-10-PasswordStore/blob/856ed94bfcf1031bf9d13514cb21b591d88ed323/src/PasswordStore.sol#L28

There is an error in the event declared - SetNetPassword. What the event does is to emit "New password set". And not "Net password set".

Impact

Wrong emit statement can cause confusion when reading emits.

Tools Used

Manual review

Recommendations

Change event SetNetPassword() to event SetNewPassword()