Summary

The following list presents findings related to information and gas optimization. These findings are provided exclusively to facilitate code improvement.

[I-1] Usage of onlyOwner() modifier instead of an if statement

Adding an onlyOwner() modifier instead of an if statement in the PasswordStore::getPassword() can improve the code readability.

[I-2] @Natspec declaration

Incomplete @Natspec declaration in the PasswordStore::setPassword() and PasswordStore::getPassword(). Suggested these minimum tags to implement for clarity:

• @author

• @title

• @notice

• @param

• @return (if applicable)

[I-3] Wrong @param in getPassword()

@param in PasswordStore::getPassword() is defined as: "newPassword. The new password to set". But the PasswordStore::getPassword() doesn't accept any input so there isn't any newPassord to set.

[I-4] Typo in the event naming in SetNetPassword();

The event name should be PasswordStore::SetNewPassword() instead of SetNetPassword().

Gas

[G-1] Storage variable declaration

In the PasswordStore contract define the string private s_password (32 bytes) variable before the address private s_owner (20 bytes) for a better slot memory allocation.

[G-2] s_owner immutable

The PasswordStore::s_owner can be defined immutable for saving gas.