Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

getPassword() access control does not work

Summary

access control violation in getPassword()

Vulnerability Details

getPassword() is implemented as a view function. Conditional logic will not revert, since transactions are not submitted for readonly operations (except for mid transaction calls for other contracts).

Impact

s_password is not private.

Tools Used

manual analysis

Recommendations

  • don't store sensitive information onchain

  • encrypt password and store hash on chain instead

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-read-storage

Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.