Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Passwords stored as string are not secure.

Summary

Store the passwords in the form of hash (rather than strings) to make it secure.

Vulnerability Details

The state variable 's_password' which stores the passwords are being stored as strings , which are not secure, and might easily be read.

Impact

anyone might be able to crack your password easily if it is stored in the form of a plaintext /strings.

Tools Used

manual analysis

Recommendations

Store in your contract hashed values of these passwords(s_passwords) using keccak256 algorithm .you may do so with javascript library Remember to hash them off-chain and send final values to the contract.

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-read-storage

Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.