Submission Details
Severity:
getPassword - private variables are lookupable by anyone, so password is not secret
Summary
private variables can be read by anyone
Vulnerability Details
In the getPassword function, it restricts access so that only owner can retrieve the password.
function getPassword() external view returns (string memory) {
@> if (msg.sender != s_owner) {
@> revert PasswordStore__NotOwner();
}
return s_password;
}
However, even though the variable in the contract is private, the value at blockchain is public. So, anyone other than the owner can retrieve it.
Impact
Anyone can read password value.
Tools Used
Manual Review
Recommendations
Do not store secret data in the contract.
Updates
Lead Judging Commences
inallhonesty
almost 2 years ago
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-read-storage
Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.