Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Private s_password can be accessed by using slot

Summary

Even though password is claimed to be private, attackers can get access to this value by using slot

Vulnerability Details

https://github.com/Cyfrin/2023-10-PasswordStore/blob/7a2fc760235c4f4809511186ff9a061c2ec68634/src/PasswordStore.sol#L14

Impact

Password can be accessed by attacker and system will get hacked

Tools Used

Manual

Recommendations

Use hashing value of password to keep it secret

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-read-storage

Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.