Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Function visibility

Summary

The 'setPassword' function is not protected by any modifier

Vulnerability Details

The 'setPassword' function can be called by any other EOA/contract.

Impact

Everybody can set a new password.

Tools Used

Manual Review

Recommendations

Add the following line of code:
if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}

The best way is to create a modifier and apply it to the function (instead of copy-pasting) this code multiple times

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-lacking-access-control

Anyone can call `setPassword` and set a new password contrary to the intended purpose.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.