Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

setPassword function parameter is clear text

Summary

The function parameter to the setPassword function is readable by everyone because it is transmitted as plain text

Vulnerability Details

The password string is transmitted as clear text, so everybody can see the parameter with which the setPassword function was called.

Impact

The password is not safe when it is transmitted as clear text. Everybody is able to retrieve it from the blockchain.

Tools Used

none

Recommendations

Passwords should always be stored as hashes, using a salt for extra security. The blockchain is transparent so everybody will be able to retrieve what values are stored in it. So use a safe way to create a hash from your password, and don't send the plain-text password to the contract.

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-read-storage

Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.