Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

storage variable reveals stored password string

Summary

The password string is stored as plain text in the s_password storage variable.

Vulnerability Details

The storage variable s_password is readable

Impact

Everybody can retrieve the password. The information stored in a private variable is only safe from other contracts accessing and modifying the value of the variable. But it is still visible to the world outside of the blockchain, and therefore not suited for storing a plaintext password string.

Tools Used

none

Recommendations

Never store the password as plain text. Only ever store the salted hash of the password.

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-read-storage

Private functions and state variables are only visible for the contract they are defined in and not in derived contracts. In this case private doesn't mean secret/confidential

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.