Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Missing access control in setPassword() function

Summary

The setPassword() function does not have access control

Vulnerability Details

As the comment above the function says, only the owner can call the setPassword() function. However, the access control for it is missing and everyone can set a new password

Impact

High

Tools Used

Manual review

Recommendations

Add an access control check, just as getPassword() function does:

if (msg.sender != s_owner) {
revert PasswordStore__NotOwner();
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-lacking-access-control

Anyone can call `setPassword` and set a new password contrary to the intended purpose.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.