Submission Details
Severity:
QA/LOW: Misleading comment at L24
Summary
At the moment the setPassword() function allows to set the same password over and over, no require() checks to prevent this, so user wont know that they're setting the previous password as the new one.
@param newPassword The new password to set.
Vulnerability Details
n/a
Impact
n/a
Tools Used
VSC
Recommendations
function setPassword(string memory newPassword) external {
++ require(newPassword != s_password, "New password same as old password!");
s_password = newPassword;
require(newPassword == s_password, "Failed to set password"); /// @audit this line is optional
emit SetNetPassword();
}
Updates
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.