Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

QA: Recommended to add one or more useful parameters to the emitted event in `SetNetPassword()` function.

Summary

Event emitted without any useful parameters is less useful than it should be.

emit SetNetPassword();

Vulnerability Details

n/a

Impact

LOW

Tools Used

VSC.

Recommendations

Related to another QA finding of mine, to add one or more parameters to the event declaration:
event SetNetPassword(address indexed owner, string password);

Then implement this into the function:

function setPassword(string memory newPassword) external {
s_password = newPassword;
-- emit SetNetPassword();
++ emit SetNetPassword(msg.sender, s_password);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.