Submission Details
Severity:
onlyOwner modifier might be considered for getPassword
Summary
The onlyOwner modifier is more readable and is considered a good practice to use in such functions.
Vulnerability Details
Code readability will be better using onlyOwner modifier.
Impact
Better code readability.
Tools Used
Manual codebase analysis.
Recommendations
+ modifier onlyOwner() {
+ require(msg.sender == owner, "Not owner");
+ _;
+ }
- function getPassword() external view returns (string memory) {
- if (msg.sender != s_owner) {
- revert PasswordStore__NotOwner();
- }
+ function getPassword() onlyOwner external view returns (string memory) {
return s_password;
}
Updates
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.